Migrate pallet-im-online to TransactionExtension API#11235
Open
RomarQ wants to merge 5 commits intoparitytech:masterfrom
Open
Migrate pallet-im-online to TransactionExtension API#11235RomarQ wants to merge 5 commits intoparitytech:masterfrom
RomarQ wants to merge 5 commits intoparitytech:masterfrom
Conversation
RomarQ
force-pushed
the
rq/im-online-migration
branch
from
ae74c5d to
65abd3a
Compare
12 tasks
substrate/frame/im-online/src/lib.rs
Outdated
Comment on lines
+399
to
+404
| #[pallet::authorize(|_source: TransactionSource, | ||
| heartbeat: &Heartbeat<BlockNumberFor<T>>, | ||
| signature: &<T::AuthorityId as RuntimeAppPublic>::Signature, | ||
| | -> TransactionValidityWithRefund { | ||
| if Pallet::<T>::is_online(heartbeat.authority_index) { | ||
| // we already received a heartbeat for this authority |
Member
There was a problem hiding this comment.
I think it would be my personal preference to have a code block this big somewhere outside of the pallet macros, and just calling it by function implemented somewhere else.
Contributor
Author
There was a problem hiding this comment.
I agree, moved the closure outside in 1ed6f34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2415 (follow-up to #10150)
Migrate
pallet-im-onlinefrom the deprecatedValidateUnsignedtrait to#[pallet::authorize], following the pattern established in #10716.Changes
ValidateUnsignedimpl with#[pallet::authorize]on theheartbeatcall.CreateBare<Call<Self>>toCreateAuthorizedTransaction<Call<Self>>.ensure_none→ensure_authorized,create_bare→create_authorized_transaction.RawOrigin::Authorized.Migration
The
Configtrait now requiresCreateAuthorizedTransaction<Call<Self>>instead ofCreateBare<Call<Self>>. Runtimes with a blanketimpl<C> CreateAuthorizedTransaction<C> for Runtime(like kitchensink) need no changes.